Repository navigation
Fix the library folders test on Windows - #275
Merged
Merged
Conversation
Compare the expanded ~ folder as a path: on Windows expanduser keeps the "/" the user typed, so the string differed from Path.expanduser(). Also drop duplicates after expanding ~, not before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test-windowsjob failed on main after 2.0.5:library_scan_dirs_from("~/Music")returnsC:\Users\runneradmin/Musicand the test compared it as a string againstPath("~/Music").expanduser(), which uses backslashes. The folder is the same, so the test now compares paths.Also: duplicates were checked before
~was expanded, so~/Musicand~/Musiccould both end up in the list. They are now checked after.🤖 Generated with Claude Code