[XiaoBinGan]

Summary

npm run format:check fails on main at 624ebb2a1, so the Static checks job fails for every pull request opened against it. This restores the formatted state of the one file responsible.

Problem and expected behavior

662ec2e45 (fix(verifiers): preserve source Evidence through shared admission) widened one import in scripts/verify-apk-signature.mjs:

import {
  mcpTextValue,
  requireMcpOutput,
} from "./lib/mcp-verifier-results.mjs";

oxfmt fits that specifier list on one line, so the committed form is unformatted. format:check runs first in Static checks and exits 1, which is why unrelated PRs fail there:

> oxfmt --check .
Checking formatting...

scripts/verify-apk-signature.mjs

Format issues found in above 1 files. Run without `--check` to fix.

Expected: npm run format:check exits 0 on main. Actual: it exits 1.

Change and scope

Ran the repository formatter on that one file. The whole diff is the import returning to one line, 1 insertion and 4 deletions. No behavior changes, no other file touched.

Intentionally not included: any reformatting beyond this file, and any edit to the max-lines warning oxlint already reports for this script (pre-existing, present on main, and not an error).

Contract and boundary impact

• Semantic owner and earliest changed stage: none. This is whitespace inside an ES module import list in a verifier script; the parsed module is identical.
• Contribution scope fit and linked maintainer decision: not applicable. Ordinary fix within existing boundaries, restoring a repository invariant that a recent commit broke.
• CLI and MCP/tool-catalog contract: none.
• Provider, bridge, target-format, or platform compatibility: none. The script's imports and behavior are unchanged.
• Evidence, artifact, provenance, or reconstruction contract: none.
• Target selection, authority, upstream behavior, and cleanup details (if applicable): none.
• Generated metadata (docs/public/product-catalog.json), package, or installation impact: none.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

• Read existing files or captured data.
• Launch or attach to a process.
• Inject instrumentation or run scripts/code.
• Change process memory, registers, files, or configuration.
• Contact network services.
• Recover protected code or work around protections.
• Documentation or usability only; no target interaction.
• Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

• Tests added or updated: none. format:check is the regression check, and it is part of Static checks.
• Base reproduction or other evidence: on a clean checkout of upstream/main at 624ebb2a1, with no local changes, npm run format:check exits 1 and names only scripts/verify-apk-signature.mjs. After this change it exits 0 over the same 6089 files.
• User-visible CLI/MCP output (if applicable): none.
• Remaining proof gaps: none for the invariant being restored.

Independent confirmation that this is a main break rather than a per-PR problem: two unrelated open PRs also report Static checks failed on this same base — #7261 (ArjenS-LA, run started 17:30:39Z) and #7258 (BeqaKs, run started 16:50:25Z).

For boundary fixes: not applicable. No boundary or lifecycle behavior changes.

For evidence-bearing changes: not applicable. This change adds or alters no observed, derived, or inferred claim.

Validation performed

• npm run format:check (on upstream/main @ 624ebb2a1, unmodified) — exit 1, scripts/verify-apk-signature.mjs reported
• npm run format:check (with this change) — exit 0, "All matched files use the correct format.", 6089 files
• npx oxfmt --check scripts/verify-apk-signature.mjs — exit 0
• npx oxlint scripts/verify-apk-signature.mjs — exit 0, "Found 1 warning and 0 errors." (the max-lines warning is present on main too)

Compatibility, safety, and release

• Breaking changes or migration steps: none.
• Real Hopper/Ghidra, browser, or OS coverage: not applicable. Unrelated to provider launch.
• Package or release metadata impact: none. The file is a repository verifier script, not shipped runtime code.
• Security, privacy, process, or containment review: none. Whitespace only.

Author readiness

Human owner: @XiaoBinGan

• I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
• I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
• I declare this PR ready for initial maintainer review.

Before merge

• This PR addresses a concrete problem or an agreed enhancement.
• Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked, or the reason for not linking one is stated above.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T18:32:31.564366Z	81fa99c	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[greptile-apps]

Confidence Score: 5/5

[Low impact] This formatting-only change appears safe to merge.

Summary

Reformats one import in scripts/verify-apk-signature.mjs to restore the repository’s expected formatting.

• The APK verifier import now fits on one line.

_{Reviews (3) · Last reviewed commit: "fix(scripts): format the APK signature v..." · Reviewed by Greptile}

[XiaoBinGan]

The failing checks here are not caused by this diff, which only adds one firmware test file.

Three separate main-level breaks are being attributed to every PR right now:

1. Static checks — 662ec2e45 left scripts/verify-apk-signature.mjs unformatted, so oxfmt --check . exits 1 on a clean main. fix(scripts): format the APK signature verifier import #7262 fixes it with a one-line change.
2. Test shard 6/8 (and 5/8, 7/8, 8/8) — tests/acceptance/applications/adbListingNumbers.test.ts fails with an assertion mismatch on main. Unrelated to firmware; feat(il2cpp): link version 24 generic method instances #7261 (a different author) fails the same test in shard 1/8.
3. Validate author declaration — pr-readiness.mjs:21 openHeadsMatching throws RequestError [HttpError]: <!DOCTYPE html>: the GraphQL query that pages all 547 open PR heads is returning an HTML error page. feat(environment): serve the writes callers make without recorded form fields #7260 hit the identical error.

Locally this PR's own test passes: firmwareStagingBudgetWiring.test.ts — 2 passed, and the branch is rebased onto current main (1b17d971d).

The commit status for PR readiness is success on this head.

[XiaoBinGan]

Landed on main independently — closing as redundant.

741f2de75 (test(ci): align source preservation and catalog assertions) repaired the same scripts/verify-apk-signature.mjs import, so rebasing this branch onto current main drops the commit with "patch contents already upstream" and leaves an empty diff. There is nothing left to merge.

For the record, this was a real main break while it lasted: on a clean checkout of 624ebb2a1, npm run format:check exited 1 and named only that file, and Static checks runs format:check first, so every PR opened against that commit failed there regardless of its own content — confirmed on #7261 (ArjenS-LA) and #7258 (BeqaKs) as well as on my own PRs. It is good that it was fixed upstream quickly.

Nothing else in this PR needs follow-up. scripts/ci/pr-readiness.mjs still fails with a GitHub GraphQL error (RequestError [HttpError]: <!DOCTYPE html> from openHeadsMatching, observed on #7260 and #7263 too), but that is a separate, upstream repository-queue condition rather than something this branch addressed.