Repository navigation
Conversation
Contributor
[Low impact] This test-only change appears safe to merge. SummaryAdds one Android filesystem-boundary test for ordinary JNI-layout libraries beneath Flutter, Unity, React Native, and Hermes library-named directories.
Reviews (1) · Last reviewed commit: "test(android): cover native libraries be..." · Reviewed by Greptile |
Owner
|
Thanks for extending the Android path-convention regression. The underlying runtime-ancestor interpretation was fixed in 8ba739f and #6862 is closed; the remaining change is an additional JNI-layout test case. I am closing this coverage-only follow-up for now. Please reopen if it demonstrates a distinct behavior or coverage gap we should retain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a filesystem-boundary regression for ordinary JNI-layout libraries nested below runtime-library-named ancestor directories. This extends coverage for the existing shared path-convention fix in 8ba739fd, associated with the already closed #6862.
Problem and expected behavior
An inert entry such as
assets/libflutter.so/lib/arm64-v8a/libordinary.sois a native-library candidate by JNI layout. Its ancestor should neither add a Flutter runtime family nor replace itsjni-library-conventionbridge basis. Existing directory/text-descendant tests do not exercise this native-library descendant.Change and scope
One test covers Flutter, Unity, React Native and Hermes ancestor names. It checks exact component membership, runtime families, all four JNI bridge candidates, inventory provenance and coverage. Only
tests/boundary/filesystem/android/application.test.tschanges, with 41 added lines.Contract and boundary impact
Evidence and regression coverage
On base
c2b0c955cd9935886dc24fdb02c031f955476457, removing only the non-final/non-framework segment guard fromnativeRuntimeConventionmakes this test fail with extraflutter,react-nativeandunityfamilies. All 11 preexisting Android tests still pass. Restoring the production helper returns the Android/Apple focused suite to green. The mutation is not included in the commit.These inert entries are JNI-path candidates, not ELF-recognized binaries. ELF-outside-lib-layout fallback, real Android devices/providers and cross-platform execution remain unverified.
Validation performed
Linux x64, Node 24.22.1 / npm 11.16.0:
npm run test:focused -- tests/boundary/filesystem/android/application.test.ts tests/boundary/filesystem/appleApplication.test.ts: 24 passed across 2 files.npm run check: failed at Knip on the existing unusedisToolFamilyIdre-export insrc/contracts/toolFamilies.ts:54. Runningnpm run knipwith the approved test addition removed reproduces the same failure on the clean base. That file is unchanged here; feat(browser): save values in browser scenarios and send them in later steps #7162 independently records the same main-baseline failure.npm run check:fast,npm run verify:architecture-guards,npm run knip:production, andnpm run lint:typed: passed. Production reachability reports advisory candidates.npm run verify:test-discovery: all 2566 test files discovered exactly once.git diff --checkand comparison against the approved one-file patch: passed.Hosted checks will be reported separately from these local results. Full local suite and real-provider results are not claimed.
Compatibility, safety, and release
No behavior/API migration, new dependency, package metadata or release change. Fixtures contain synthetic, inert data and retain existing cleanup ownership.
AI assistance: OpenAI Codex prepared this test and ran the checks above. Human readiness remains pending below.
Author readiness
Human owner: @Leozz04
Before merge
type(scope): outcome.