(HG3): fix img_jpg RGB swapping and img_al null-terminator check. - #478
Open
trigger-segfault wants to merge 1 commit into
Open
(HG3): fix img_jpg RGB swapping and img_al null-terminator check.#478trigger-segfault wants to merge 1 commit into
trigger-segfault wants to merge 1 commit into
Conversation
* `"img_jpg"` tag format unpack operation was swapping RGB -> BGR when already in BGR format. * `"img_al"` tag name had two null-terminator checks. And apparently CatSystem 2 does not guarantee anything after the first null-terminator in a fixed-length string *(yikes)*. This can be observed with a few assets in the `cs2_full_v301` toolset, like `be01S_0000001.hg3`: `69 6D 67 5F 61 6C 00 B5` : `"img_al.5"`
trigger-segfault
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple corrections to
img_jpgunpacking in HG-3 images.Changes
"img_jpg"tag format unpack operation was swapping RGB -> BGR when already in BGR format."img_al"tag name had two null-terminator checks. And apparently... CatSystem 2 does not guarantee anything after the first null-terminator in a fixed-length string (yikes). This can be observed with a few assets in thecs2_full_v301toolset:69 6D 67 5F 61 6C 00 B5:"img_al.5""img_altags will have a clean two null bytes in the tag name, this seems to only be an infrequent issue.