[feat, refactor]: add eslint import order rules, refactor import order#301
Open
yoosion030 wants to merge 6 commits into
Open
[feat, refactor]: add eslint import order rules, refactor import order#301yoosion030 wants to merge 6 commits into
yoosion030 wants to merge 6 commits into
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @morethanmin on Vercel. @morethanmin first needs to authorize it. |
Author
아아 다른 PR에 올린 커밋이 포함되었네요,, 수정해서 다시 업로드 하겠습니다! |
Author
|
@morethanmin 수정했습니다 :) |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
morethanmin
approved these changes
Dec 17, 2023
Owner
morethanmin
left a comment
morethanmin
left a comment
There was a problem hiding this comment.
늦게 리뷰 드려서 죄송합니다 ㅠㅠ 빌드오류가 발생해서 한번 확인 부탁드리겠습니다. 감사합니다!
morethanmin
reviewed
Dec 24, 2023
Owner
morethanmin
left a comment
morethanmin
left a comment
There was a problem hiding this comment.
아직 빌드오류가 발생하는 것 같아 로컬에서 한번 잡아주시면 좋을 것 같습니다.
감사합니다!
Author
|
네, 다시 한번 확인해보겠습니다 :) |
Owner
|
해당 PR 제가 이어서 작업하겠습니다 ~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While looking at the code, I saw that the relative path and order were not organized in the import code.
So we added a function to organize the order. The following changes were made to add this function:
src/path from being overused.src/components->@/componentsrulesto.eslintrc.jsonfor organize import orderbefore
after
You may be reluctant to merge because there are a lot of file changes, but the following problems can be improved with these changes:
Match code style even when file path changes
It is for this benefit that I request the change.
PR Checklist