Skip to content

Remove cargo afl installation#64

Closed
tokatoka wants to merge 1 commit intomorehouse:masterfrom
tokatoka:no_cargo_afl
Closed

Remove cargo afl installation#64
tokatoka wants to merge 1 commit intomorehouse:masterfrom
tokatoka:no_cargo_afl

Conversation

@tokatoka
Copy link
Copy Markdown
Contributor

If I understand the Dockerfile correctly, smite is not really instrumenting any Rust code. (and neither is it using cargo afl subcommands)

so I think we can delete it from the Dockerfile

fwiw; it was removed from fuzzamoto too

Copy link
Copy Markdown
Contributor

@ekzyis ekzyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@erickcestari
Copy link
Copy Markdown
Contributor

erickcestari commented Apr 30, 2026

If I understand the Dockerfile correctly, smite is not really instrumenting any Rust code. (and neither is it using cargo afl subcommands)

It's instrumenting the rust-lighting (LDK) code, that's why it's only used in the LDK Dockerfile. It won't instrument any Smite code. If we remove it, the fuzzer will not get any coverage feedback from LDK workloads.

Here, it compiles rust-lightning with instrumentation.

cargo afl build --release

fwiw; it was removed from fuzzamoto too

I believe they removed it because they only need to instrument the C++/Go code, and they don't need to compile Fuzzamoto with instrumentation.

Here's a bit more context: #2

@tokatoka
Copy link
Copy Markdown
Contributor Author

I see.
I thought this cargo-afl came from the dockerfile of fuzzamoto, but didn't know it was really actually used.
thanks for clarifying this!

@tokatoka tokatoka closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants