You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I understand the Dockerfile correctly, smite is not really instrumenting any Rust code. (and neither is it using cargo afl subcommands)
It's instrumenting the rust-lighting (LDK) code, that's why it's only used in the LDK Dockerfile. It won't instrument any Smite code. If we remove it, the fuzzer will not get any coverage feedback from LDK workloads.
Here, it compiles rust-lightning with instrumentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand the Dockerfile correctly, smite is not really instrumenting any Rust code. (and neither is it using
cargo aflsubcommands)so I think we can delete it from the
Dockerfilefwiw; it was removed from fuzzamoto too