Skip to content

Fix for "Fill user+pass" menu #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
extensionssoft wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for "Fill user+pass" menu #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72331c3
Fix for "Fill user+pass" menu
extensionssoft Aug 5, 2026
fa82697
fix for manual filling of credentials within 30sec
extensionssoft Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extension_mv3/content_scripts/cip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ var cip = {

chrome.runtime.sendMessage({
'action': 'retrieve_credentials',
'args': [cip.url, cip.submitUrl, true, true]
'args': [cip.url, cip.submitUrl, true, true, mcCombs.forceFilling]
}, cip.retrieveCredentialsCallback);
},
fillUserNameOrPasswordField: function()
Expand All @@ -109,7 +109,7 @@ var cip = {

chrome.runtime.sendMessage({
'action': 'retrieve_credentials',
'args': [document.location.origin, action, true, true]
'args': [document.location.origin, action, true, true, mcCombs.forceFilling]
}, mcCombs.retrieveCredentialsCallback);
},
/**
Expand Down Expand Up @@ -312,7 +312,7 @@ var cip = {

chrome.runtime.sendMessage({
'action': 'retrieve_credentials',
'args': [cip.url, cip.submitUrl, true, true]
'args': [cip.url, cip.submitUrl, true, true, false]
}, function (credentials) {
cipDebug.log('cip.fillInCredentials()');
cip.retrieveCredentialsCallback(credentials, true);
Expand All @@ -337,8 +337,8 @@ var cip = {
*/
retrieveAndFillUserAndPassword: function ()
{
mcCombs.forceFilling = true;
cip.initCredentialFields(true);
mcCombs.forceFilling = true;
},

/**
Expand Down
17 changes: 10 additions & 7 deletions extension_mv3/vendor/mooltipass/device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ mooltipass.device.onTabUpdated = function(tabId, removeInfo)
* @param forceCallback
* @param triggerUnlock
*/
mooltipass.device.retrieveCredentials = function(callback, tab, url, submiturl, forceCallback, triggerUnlock)
mooltipass.device.retrieveCredentials = function(callback, tab, url, submiturl, forceCallback, triggerUnlock, manualFilling)
{
if (background_debug_msg > 3) mpDebug.log('%c device: %c retrieveCredentials ','background-color: #e244ff','color: #484848', arguments);

Expand Down Expand Up @@ -733,13 +733,16 @@ mooltipass.device.retrieveCredentials = function(callback, tab, url, submiturl,
return;
}
}
if (mooltipass.device.checkInLastCredentialsRequests(tab.id, submiturl)){
mooltipass.device.addToLastCredentialsRequests(tab.id, submiturl);
return;

if (!manualFilling){
if (mooltipass.device.checkInLastCredentialsRequests(tab.id, submiturl)){
mooltipass.device.addToLastCredentialsRequests(tab.id, submiturl);
return;
}

mooltipass.device.addToLastCredentialsRequests(tab.id, submiturl);
}

mooltipass.device.addToLastCredentialsRequests(tab.id, submiturl);


// If our retrieveCredentialsQueue is empty and the device is unlocked, send the request to the app. Otherwise, queue it
mooltipass.device.retrieveCredentialsQueue.push({'tabid': tab.id, 'callback': callback, 'domain': parsed_url.domain, 'subdomain': parsed_url.subdomain, 'tabupdated': false, 'reqid': mooltipass.device.retrieveCredentialsCounter, 'tab': tab});

Expand Down
Loading