fix: restart Windows agent on plugin version drift - #194
Closed
qtcqtc wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the PR — the fix itself is correct and complete across all three render copies (read and write sides of the fingerprint stay symmetric, matching the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193.
The Windows launcher already loads
plugin-version.ps1, but its healthy-process fingerprint omits the resultingMONK_PLUGIN_VERSION. When a plugin release reuses the same Agent binary, the existing companion therefore stays alive with stale release attribution.This change:
plugin-version.ps1;The regression proves all three lifecycle cases:
old-version;new-versionrestarts once and updates state.Verified on Windows 11 / Windows PowerShell 5.1:
All generated PowerShell launcher copies are byte-identical and
git diff --checkpasses.The unrelated readiness-timeout test harness failure on Windows PowerShell 5.1 is tracked in #191 / #192.