Benchmarks for eager_load functionality - #6163
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new performance benchmark scenarios to measure Mongoid #eager_load behavior across more complex association patterns (subclass-defined associations, references inside embedded documents, and polymorphic belongs_to), expanding the existing perf/benchmark_eager_load.rb script and its supporting model definitions.
Changes:
- Add additional Mongoid model classes in
perf/models.rbto represent PR #6158-relatedeager_loadscenarios. - Extend
perf/benchmark_eager_load.rbto generate scenario data and run new benchmark sections for subclass, embedded-reference, and polymorphic association cases. - Introduce a
keep-dataCLI flag to reuse an existing dataset instead of purging/reseeding each run.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| perf/models.rb | Adds benchmark-only models for subclass, embedded-reference, and polymorphic association scenarios. |
| perf/benchmark_eager_load.rb | Adds dataset setup and benchmark cases for the new scenarios; adds keep-data option to skip purge/reseed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+13
| if ARGV.include?('keep-data') | ||
| puts 'reusing existing data' | ||
| else | ||
| Mongoid.purge! |
comandeo-mongo
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just adds some benchmarks for measuring the effectiveness of the
#eager_loadfeature.