Skip to content

PYTHON-5566 & PYTHON-3132 Add minimum version checks for remaining test variants #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
blink1073 wants to merge 11 commits into
base: master
Choose a base branch
from
Open

PYTHON-5566 & PYTHON-3132 Add minimum version checks for remaining test variants #2650

blink1073 wants to merge 11 commits into from

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 12, 2025 •
edited
Loading

PYTHON-5566

Changes in this PR

Updates tests to use minimum dependencies when the minimum python version is used.
For version mins, I selected the oldest versions that passed the current test suite.
The uv lock is updated because of the version changes.

Test Plan

Patch build of all the min-dep tests: https://spruce.mongodb.com/version/693c66cdf6f71300075c6921/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@blink1073 blink1073 requested a review from a team as a code owner December 12, 2025 22:04
@blink1073 blink1073 changed the title PYTHON-5566 Add minimum version checks for remaining test variants PYTHON-5566 & PYTHON-3132 Add minimum version checks for remaining test variants Dec 12, 2025
blink1073
blink1073 commented Dec 12, 2025
View reviewed changes
pymongo/ocsp_support.py
)


def _load_trusted_ca_certs(cafile: str) -> list[Certificate]:
Copy link
Member Author

@blink1073 blink1073 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for PYTHON-3132

caseyclements
caseyclements requested changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This timeout failure seems persistent. I reran. :(

@blink1073
Copy link
Member Author

blink1073 commented Dec 16, 2025

This timeout failure seems persistent. I reran. :(

It passed on the next two attempts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caseyclements caseyclements Awaiting requested review from caseyclements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blink1073 @caseyclements