breaking: modernize LinearProgressBar API from deprecated enums to string unions#3272
Open
rivka-ungar wants to merge 2 commits intovibe4from
Open
breaking: modernize LinearProgressBar API from deprecated enums to string unions#3272rivka-ungar wants to merge 2 commits intovibe4from
rivka-ungar wants to merge 2 commits intovibe4from
Conversation
…ring unions - Deprecate ProgressBarType and ProgressBarStyle enums in LinearProgressBarConstants - Replace with type-safe string union types: ProgressBarStyle - Update all component interfaces to use string union types - Maintain backward compatibility via static properties - Update tests and documentation to use string literals BREAKING CHANGE: ProgressBarType and ProgressBarStyle enums are deprecated. Use string literal values instead: "primary", "secondary", "positive", "negative", "warning", "none". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
PR Reviewer Guide 🔍(Review updated until commit 3edf7b9)Here are some key observations to aid the review process:
|
- Rename LinearProgressBar directory to ProgressBar - Rename all LinearProgressBar.* files to ProgressBar.* - Update all import paths to reference new file names - Maintain component functionality and test coverage This aligns file names with the actual component name ProgressBar for better consistency in the codebase.
Contributor
|
📦 Bundle Size Analysis ✅ No bundle size changes detected. Unchanged Components
📊 Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
• Deprecate ProgressBarType and ProgressBarStyle enums in favor of type-safe string unions
• Replace enum-based API with modern string literal types: "primary" | "secondary" | "positive" | "negative" | "warning" | "none"
• Update all component interfaces, tests, and documentation to use string literals
• Maintain backward compatibility through preserved static properties
Breaking Changes
ProgressBarTypeenum → deprecated (no direct replacement - type removed from interface)ProgressBarStyleenum →ProgressBarStylestring union typeTask Link
Monday.com Task
Test Plan
🤖 Generated with Claude Code
PR Type
Enhancement, Other
Description
Rename LinearProgressBar component to ProgressBar for consistency
Update all type names from LinearProgressBar* to ProgressBar*
Migrate file structure from LinearProgressBar directory to ProgressBar
Update test IDs and component identifiers across test constants
Refactor all imports, exports and documentation references
Diagram Walkthrough
File Walkthrough
6 files
Delete old LinearProgressBar types fileCreate new ProgressBar types with renamed exportsUpdate import path to ProgressBar stylesheetUpdate exports from LinearProgressBar to ProgressBarUpdate imports and type references to ProgressBarRename component and interface from LinearProgressBar to ProgressBar2 files
Update test IDs and component identifiersUpdate test IDs and component identifiers2 files
Update test imports and component referencesUpdate test imports and component references5 files
Update component description import and mappingRename component and update documentation referencesUpdate documentation title and import statementsUpdate component imports and usage in helpersUpdate component imports, types and story metadata3 files