fix(MenuItemIcon): remove deprecated label prop#3262
Merged
rivka-ungar merged 4 commits intovibe4from Feb 26, 2026
Merged
Conversation
The MenuItemIcon internal component had a label prop marked for removal
in the next major version (TODO: [breaking] remove in next major).
The prop was a no-op — accepted but never passed to the underlying Icon.
Changes:
- MenuItemIcon.types.ts: remove deprecated label prop
- MenuItemIcon.tsx: remove label from destructuring + eslint-disable comment
- MenuItem.tsx: remove label={iconLabel} and label={rightIconLabel} usages;
remove now-unused iconLabel and rightIconLabel derived variables
- Update VIBE4_MIGRATION_GUIDE.md and VIBE4_CHANGELOG.md
BREAKING CHANGE: MenuItemIcon.label prop removed (was a no-op).
No migration needed for MenuItem users.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
PR Reviewer Guide 🔍(Review updated until commit f5eab62)Here are some key observations to aid the review process:
|
Contributor
|
📦 Bundle Size Analysis ✅ No bundle size changes detected. Unchanged Components
📊 Summary:
|
…rough - Remove rightIconAriaLabel from props interface and destructuring since it's no longer consumed after label removal - Stop swallowing aria-label — let it flow through baseMenuProps to the DOM for proper accessibility support Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
qodo-free-for-open-source-projects
bot
added
Review effort 3/5
and removed
Review effort 2/5
labels
rivka-ungar
changed the title
qodo-free-for-open-source-projects
bot
added
Review effort 2/5
and removed
Review effort 3/5
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
labelprop from internalMenuItemIconcomponenticonLabel/rightIconLabelderived variables fromMenuItemVIBE4_MIGRATION_GUIDE.mdandVIBE4_CHANGELOG.mdBreaking Changes
MenuItemIcon.labelprop removed (was already a no-op — accepted but never passed to the underlyingIconcomponent)MenuIteminternaliconLabel/rightIconLabelvariables removedMigration
No action required for
MenuItemusers. The removedlabelprop onMenuItemIconhad no effect. If you usedMenuItemIcondirectly (internal component, not exported from@vibe/core), remove anylabelprop.Task Link
Monday.com Task
Test Plan
🤖 Generated with Claude Code
PR Type
Bug fix
Description
Remove deprecated
labelprop fromMenuItemIconcomponentRemove unused
iconLabel/rightIconLabelvariables fromMenuItemRemove unused
rightIconAriaLabelprop fromMenuIteminterfaceAllow
aria-labelto pass through to DOM for accessibilityUpdate migration guide and changelog documentation
Diagram Walkthrough
File Walkthrough
MenuItemIcon.types.ts
Remove deprecated label prop from interfacepackages/core/src/components/Menu/MenuItem/components/MenuItemIcon/MenuItemIcon.types.ts
labelprop fromMenuItemIconPropsinterfaceMenuItem.tsx
Remove label props and cleanup MenuItem componentpackages/core/src/components/Menu/MenuItem/MenuItem.tsx
rightIconAriaLabelprop fromMenuItemPropsinterfacerightIconAriaLabelfrom destructuring in componentaria-labelfrom destructuring to allow passthroughiconLabelandrightIconLabelderived variableslabelprop from bothMenuItemIconcomponent usagesMenuItemIcon.tsx
Remove label parameter from componentpackages/core/src/components/Menu/MenuItem/components/MenuItemIcon/MenuItemIcon.tsx
labelparameter from destructuringVIBE4_CHANGELOG.md
Document MenuItem label prop removalVIBE4_CHANGELOG.md
labelpropVIBE4_MIGRATION_GUIDE.md
Add MenuItem migration guide sectionVIBE4_MIGRATION_GUIDE.md
MenuItem.labelbadge prop is unaffectedMenuItemIcon.labelwas a no-op