Skip to content

fix(openapi-loader): process path-level parameters for OpenAPI operat…#61

Merged
ItayKal-monday merged 4 commits intomasterfrom
fix/itayka/ignored-params
Feb 1, 2026
Merged

fix(openapi-loader): process path-level parameters for OpenAPI operat…#61
ItayKal-monday merged 4 commits intomasterfrom
fix/itayka/ignored-params

Conversation

@ItayKal-monday
Copy link
Collaborator

Fix: Process Path-Level Parameters in OpenAPI Loader

Issue

The OpenAPI loader only processed operation-level parameters (get: parameters: []) and ignored path-level parameters (/foo/{bar}: parameters: []). Per OpenAPI spec, path-level parameters should apply to all operations under that path.

Example:

paths:
  /foo/{bar}:
    parameters:                    # ❌ Ignored
      - name: bar
        in: path
        required: true
    get:
      parameters:                   # ✅ Processed
        - name: limit
          in: query

Solution

  • Added mergeParameters() to merge path and operation parameters - avoid dupes.
  • Extract path-level parameters in loadOpenAPI() before processing operations
  • Merge parameters in convertOperation() (operation-level overrides path-level on conflict)

Result: Path-level parameters are now included in schema and handlers. Operation-level parameters override path-level ones when conflicts exist (same name + in).

Copy link
Collaborator

@encodedz encodedz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

Can u add unit test covering this ? (if its not too much hussle)

@ItayKal-monday ItayKal-monday merged commit f7f274e into master Feb 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants