Skip to content

fix(report)!: name narrowing, evidence gaps and accepted gaps apart in every format - #249

Merged
mokevnin merged 1 commit into
mainfrom
fix/216-name-notes-apart
Nov 19, 2026
Merged

mokevnin merged 1 commit into
mainfrom
fix/216-name-notes-apart

Conversation

@mokevnin

Copy link
Copy Markdown
Owner

Closes #216

Summary

Each note a run makes of itself has one kind, named the same in every format; no output says "partial" (ADR 0001).

 GitHub title
-easement partial                  (narrowing and evidence gaps alike)
+easement narrowed                 notice
+easement evidence-gap             warning, error under --require-evidence
+easement accepted-gap             notice, one per uncovered_ok entry (globs, because, files)

 SARIF notification
+descriptor.id: narrowed | evidence-gap | accepted-gap | unused-allowance | cache
+tool.driver.notifications declares each kind once
+accepted gaps: level note, their files as locations

 JUnit <system-out>
+narrowed: …
+evidence gap: …; to close: …
+accepted gap (uncovered_ok: tools/**) because …; files: …   (never a failed case)

 propose summary
-… graph not judged (partial)
+… graph not judged (narrowed: --no-graph; 1 evidence gap)

 graph (stderr)
-easement: partial: <message>
+the gap block every other command prints: graph_gaps (accepted files included) + accepted gaps

report::Confidence and Coverage::confidence() are gone. The uncovered_ok description in easement schema no longer says "partial" either.

Evidence

  • Before: formats::no_output_says_partial (check in every format, graph, propose, impact, why, suggest, review, baseline, init, over a narrowed run with an evidence gap and an accepted gap) fails on ::notice title=easement partial::.
    After: it passes, as do the new formats::an_accepted_gap_is_a_note_in_every_ci_format, formats::a_diff_run_names_the_narrowing_and_the_evidence_gap_apart, the graph cases in evidence.rs/externals.rs/cli.rs and the propose --no-graph summary. cargo nextest run: 829 passed; mise run check green.
  • Snapshots: two change, each one line, title=easement partial → title=easement narrowed.

Merge Danger

Door: two-way

Revert restores the old titles and text.

Blast Radius: CI consumers

Breaking for readers of the GitHub annotation titles, the SARIF notifications and JUnit <system-out> text, and of graph's stderr (fix(report)!: with a BREAKING CHANGE: footer, so release-please bumps accordingly).

🤖 Generated with Claude Code

…n every format

Each note a run makes of itself has one kind (`narrowed`, `evidence-gap`,
`accepted-gap`, `unused-allowance`, `cache`), and every output format names
it the same way; none says "partial".

- GitHub titles annotations `easement <kind>`, and gives one
  `easement accepted-gap` notice per `uncovered_ok` entry.
- SARIF gives the accepted gaps as `note` notifications with their files as
  locations; each notification carries its kind as `descriptor.id`, declared
  in `tool.driver.notifications`.
- JUnit opens each line of `<system-out>` with its kind and lists accepted
  gaps there, never as a failed test case.
- `propose` ends with the reasons, `(narrowed: --no-graph; 1 evidence gap)`,
  instead of `(partial)`.
- `graph` prints on stderr the gaps that leave dependencies out of the
  drawing, accepted files among them, and the accepted gaps, as every other
  command does.
- `report::Confidence` and `Coverage::confidence()` are gone.

Closes #216

BREAKING CHANGE: GitHub annotations of a narrowing or an evidence gap are
titled `easement narrowed` and `easement evidence-gap` instead of
`easement partial`; SARIF notifications carry a descriptor and JUnit's
`<system-out>` lines open with their kind; `propose` no longer ends with
`(partial)`; `graph` prints its gaps on stderr as a block instead of
`easement: partial: ...` lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mokevnin
mokevnin merged commit c0a22d0 into main Nov 19, 2026
5 checks passed
@mokevnin
mokevnin deleted the fix/216-name-notes-apart branch November 19, 2026 13:27
mokevnin added a commit that referenced this pull request Nov 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mokevnin added a commit that referenced this pull request Nov 19, 2026
* chore(main): release 0.10.0

* docs(changelog): complete the breaking change of #249

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name narrowing, evidence gaps and accepted gaps apart in every output format

1 participant