Repository navigation
refactor: rename Edge to ComponentDep, and the flow's Edge to NodeReach - #246
Merged
Merged
Conversation
The type that carries a dependency of one component on another was called `Edge`, a word GLOSSARY.md avoids for a dependency. It is `ComponentDep` now, with the variables, parameters and doc comments that hold one saying dependency, not edge or import. The flow's reference from one node to another, also an `Edge`, is `NodeDep`, and `Flow::edges` is `Flow::node_deps`. No behaviour, output or snapshot changes. Closes #218 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Dep Review of the rename: `dep` already names a `lang::Dep`, so the locals that hold a `ComponentDep` are `component_dep`, as those of a `NodeDep` are `node_dep`. The arrow of the drawn graph counts its dependencies in `count`. The doc comments of `Step::file`, of the flow and of `NodeDep` say what they hold: a line that writes a step, a node reaching another. Refs #218 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pendency for what a file writes Refs #218 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #218 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GLOSSARY.mdlists "edge" under Avoid for a dependency. The code now uses dependency names for these types:ComponentDepnow saycomponent_deps/component_depand "dependency", not edge or import. Plaindepstays forlang::Dep. The drawn graph's arrow counts its dependencies incount.NodeReach, not "dependency": the flow links methods through references, and the glossary says a method reached through a value is not a dependency.deps_of,dep_list,fake_deps,add_dep).diagram.rs.diff.rs, which means its boundary.edgein a config test.Closes #218
Evidence
grep -rnw Edge srcfindsstruct Edgeincheck.rsandflow.rs.After: nothing.
mise run checkis green,cargo nextest runpasses 821/821, and no.snap.newappears.Merge Danger
Door: two-way
Only names, doc comments,
expectmessages and test names change. No output, JSON field or snapshot changes. None of these types is serialized.Blast Radius: none
🤖 Generated with Claude Code