feat(server): Add build tags to enable cloud backends#62
Open
feat(server): Add build tags to enable cloud backends#62
Conversation
Add tag_s3.go, tag_gcs.go, tag_azblob.go guarded by server_s3, server_gcs, server_azblob build tags respectively. The default build remains osfs/memfs only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_s3,server_gcs,server_azblobbuild tags that opt-in cloud backends for s2-serverosfs/memfsonly — official release binaries and Docker images are unchangedFiles
server/tag_s3.go—//go:build server_s3→_ "github.com/mojatter/s2/s3"server/tag_gcs.go—//go:build server_gcs→_ "github.com/mojatter/s2/gcs"server/tag_azblob.go—//go:build server_azblob→_ "github.com/mojatter/s2/azblob"Test plan
go build ./server/...passes without tagsgo build -tags server_s3,server_gcs,server_azblob ./cmd/s2-server/passesgo test ./server/...passesgolangci-lint run ./server/...— 0 issues