Repository navigation
feat(domain): localization foundation with typed t() helper - #20
Merged
Merged
Conversation
moiz-za
force-pushed
the
feat/localization-foundation
branch
from
October 2, 2026 07:54
0fca93a to
75dda34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a minimal, typed localization foundation as a pure domain unit (closes #2).
src/domain/locale/en-US.json— flat dictionary of the app's currently hardcoded UI strings (tray menu labels, window titles, dialog copy)src/domain/locale/index.ts— typedt(key, variables?)with fallback toen-US,{placeholder}interpolation, andregisterLocale/setLocale/availableLocalesfor adding languagestests/locale.test.ts— 7 tests covering known keys, fallback-to-English, interpolation, unknown placeholders, and unknown-locale fallbacktsconfig.json— enablesresolveJsonModuleso the JSON dictionary is typed and emitted todist/Data-only and dependency-free; not wired into the UI yet (as specified in the issue).
Verification
npm run typecheck && npm run lint && npm run check:arch && npm run build && npm test— all pass (166 tests).