Skip to content

Replace chrono feature with jiff#148

Open
fabian-braun wants to merge 6 commits into
mainfrom
replace-chrono-with-jiff
Open

Replace chrono feature with jiff#148
fabian-braun wants to merge 6 commits into
mainfrom
replace-chrono-with-jiff

Conversation

@fabian-braun

@fabian-braun fabian-braun commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the optional chrono feature/dependency with jiff
  • port RFC3339 parse/format, Display, and conversion impls to jiff equivalents
  • document the breaking feature change and update the accepted infinity formatting expectation

Fixes #147

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the optional chrono-backed integration with a jiff-backed one, migrating RFC3339 parsing/formatting, Display, and conversion impls behind a new jiff feature flag, and updates expectations around infinity formatting.

Changes:

  • Replace the optional chrono feature/dependency with jiff, including deleting src/chrono.rs and adding src/jiff.rs.
  • Port Time RFC3339 parse/format and Display/conversion impls to jiff equivalents, including ±∞ formatting for out-of-range values.
  • Update tests and changelog to reflect the feature rename and new formatting expectations.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/serde.rs Switch RFC3339 serde helper gating from chrono to jiff.
src/lib.rs Rename public feature module to jiff and adjust formatting-related tests.
src/jiff.rs New jiff-based formatting/parsing/conversion implementations and Display impls.
src/chrono.rs Removed chrono-based integration module.
CHANGELOG.md Document the breaking feature rename (chrono → jiff).
Cargo.toml Swap optional dependency/feature from chrono to jiff.
Cargo.lock Update lockfile to remove chrono-related crates and add jiff-related crates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/jiff.rs
Comment thread CHANGELOG.md Outdated
Comment thread src/jiff.rs
fabian-braun and others added 3 commits June 15, 2026 18:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@fabian-braun fabian-braun marked this pull request as ready for review June 15, 2026 18:09
@fabian-braun fabian-braun requested a review from jankeu as a code owner June 15, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace chrono with jiff

2 participants