Repository navigation
Add Vanilla JavaScript and React foundation templates - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundry can now generate Vanilla JavaScript and React (JavaScript) applications with
--template vanilla-jsand--template react. Both foundations ship as directly embedded source files, appear in the interactive menu and registry, and print explicit npm setup instructions without installing dependencies during generation.Each template includes Vite, native ES modules, a feature-first
app/pages/features/sharedstructure, public static assets, an accessible example feature, shared styles/UI, public environment configuration, and an HTTP helper that handles unsuccessful/empty responses and cancellation. ESLint, Prettier, Vitest, Testing Library, exact dependency versions, and npm lockfiles provide repeatable checks and builds. React enables StrictMode and Hooks linting; Vanilla JS demonstrates listener teardown and isolated DOM state. Template READMEs document dependency direction and where new code belongs.Generation now substitutes project settings in HTML, JavaScript, JSX, CSS, manifests, and lockfiles, with regression coverage for both web templates and project metadata. Node.js/npm are included in
doctor. The project metadata package moves frominternal/projectconfigtointernal/config, with declarations, imports, and callers updated.Validation:
make check smoke: formatting, all Foundry tests, vet, build, and existing generation/add smoke checks passed.npm ciandnpm run checkpassed for both templates, including formatting, lint, 6 behavior tests per template, and production builds../scripts/build-release.sh ci: all six release targets passed.git diff --checkpassed.