Fix/manager language mix in settings#406
Draft
Copilot wants to merge 3 commits intofix/manager-language-mix-in-settingsfrom
Draft
Fix/manager language mix in settings#406Copilot wants to merge 3 commits intofix/manager-language-mix-in-settingsfrom
Copilot wants to merge 3 commits intofix/manager-language-mix-in-settingsfrom
Conversation
Co-authored-by: yama <73999+yama@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix language mix in manager settings
Fix/manager language mix in settings
Mar 5, 2026
Member
|
@copilot 再レビューを。 |
Co-authored-by: yama <73999+yama@users.noreply.github.com>
Contributor
Author
再レビューの結果、前回修正で見落とした問題を発見・修正しました(コミット
その他の確認点:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
管理画面設定の言語キー解決における正規表現の堅牢化と、
$lang_keys未初期化コンテキストへの防御的チェックを追加。変更内容
get_lang_keys()の正規表現を(.*?)から((?:(?!\1)[^\\\\]|\\\\.)*)へ改善$_lang['test\'key'])を正しく抽出.*?の遅延マッチはバックスラッシュエスケープを考慮せず、エスケープ済みクォートでキーが誤切れする問題を修正get_langs_by_key()に$lang_keysの型チェックによる早期リターンを追加mutate_settings.dynamic.php以外のコンテキストから呼ばれた場合の未初期化foreachエラーを防止get_lang_options()にも同様の$lang_keys型チェックによる早期リターンを追加$keyなし呼び出し時のarray_keys($lang_keys)が未初期化状態で警告/TypeError を発生させる問題を防止allowed_ipsベースの制御へ統一install-config.phpの自動削除処理を追加(成功/失敗メッセージとログ出力を追加).agent/,.codex/,.env*,manager/includes/cli/など)assets/docs/release-process.mdを簡潔化し、除外設定のSSOTをrelease.ymlに明示確認手順
get_langs_by_key()およびget_lang_options()を$lang_keys未初期化状態で呼んだ場合にそれぞれ空配列・空文字列が返ることを確認install-config.phpを配置してインストールを実行し、IP制御のみで判定されることを確認install-config.phpが自動削除されること(または失敗時に警告表示されること)を確認release.ymlのPrepare dist directory相当のrsyncをローカル実行し、追加除外対象がdist/に含まれないことを確認備考
.agent/・.codex/配下の運用ファイル追加が含まれます。allowed_ips前提へ移行が必要です。get_langs_by_key()とget_lang_options()の防御的チェックは対称性を保つよう追加しており、呼び出し元がmutate_settings.dynamic.phpに限定される場合も安全。💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.