fix(queue): ensure claim columns when Phinx did not run - #122
Merged
Conversation
Sites that got Sendex 2.0 maps without a successful #105 migration fail xPDO SELECTs on sxQueue.claimed_at. Ensure claimed_at/attempts/expires_at on Sendex bootstrap so mgr and cron work before a full package remigrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production upgrades that deliver Sendex 2.0 maps without a successful Phinx run (
20260725190000_add_queue_claim_fields) fail withUnknown column 'sxQueue.claimed_at' in 'field list'.Sendexnow ensuresclaimed_at,attempts, andexpires_atonce per process afteraddPackage, using$xpdo->prepare(MODX 2/3). Concurrent ALTERs that hit duplicate-column are treated as success when the columns are already present.Verified locally: drop columns → ensure restores them →
getCount('sxQueue')works. PHPUnit 277 green, PHPCS green.