fix(mgr): restore newsletter grid after create (#114) - #115
Merged
Conversation
getlist JOIN/COUNT/GROUP BY broke under MySQL ONLY_FULL_GROUP_BY once a newsletter existed, so save looked hung and the grid stayed empty. Use a subscriber-count subquery and return a plain create payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
После «Сохранить» подписка писалась в БД, но mgr зависал на «Загружается…», а после перезагрузки грид оставался пустым (повтор с тем же именем давал «уже существует»).
getlistстроил JOIN +COUNT+GROUP BY, что падает на MySQL сONLY_FULL_GROUP_BY, как только появляется хотя бы одна строка. Пустой список работал, поэтому баг проявлялся только после первого успешного create.Исправление: correlated subquery для числа подписчиков без
GROUP BY; create возвращаетtoArray()для стабильного JSON в ExtJS.Fixes #114