Fix Apple GPU parsing #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were incorrectly grouping the CPU with the metal version. Metal version is tied to the hardware + the OS version, which is also printed from this same CLI so we can directly use that instead.
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Sep 25, 2025
To pull in modular/rules_mojo#61 MODULAR_ORIG_COMMIT_REV_ID: 95a2bea2e34d81f598820b904a1dcb5980f4ede0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were incorrectly grouping the CPU with the metal version.
Metal version is tied to the hardware + the OS version, which is also
printed from this same CLI so we can directly use that instead.