Repository navigation
Match API and internal packages on package boundaries - #33
Merged
Merged
Conversation
isPublicApi and the internal-package predicate compared class names by string prefix after stripping the trailing dots, so an API package of .c. also matched com.example.b.cache, and .api. matched .apiinternal. Both now go through ModuleDefinition.classMatchesPackagePattern, which matches the package itself or a sub-package and nothing else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kau5wVS3uJKM78ge7ULSGJ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kau5wVS3uJKM78ge7ULSGJ
omphile-matheolane
force-pushed
the
fix/package-pattern-boundary
branch
from
November 14, 2026 11:01
a395c2a to
421e409
Compare
omphile-matheolane
added a commit
that referenced
this pull request
Nov 17, 2026
…dary Match API and internal packages on package boundaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes on this branch.
Package matching stops at a package boundary.
isPublicApiand the internal-package predicate compared class names by string prefix, so an API package of.c.also matchedcom.example.b.cache, and.api.matched.apiinternal.. Both now go throughModuleDefinition.classMatchesPackagePattern, which matches the package itself or a sub-package and nothing else.ModuleDefinitionTestcovers sibling packages sharing a prefix, sub-packages, absolute patterns with and without the trailing dots, and nested classes.Zenodo metadata. Adds
.zenodo.jsonso each GitHub release is archived with a DOI once the Zenodo GitHub integration is switched on for the repo.