This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Disable CSS transitions when changing theme#1659
Open
n1ckoates wants to merge 1 commit intomodrinth:masterfrom
Open
Disable CSS transitions when changing theme#1659n1ckoates wants to merge 1 commit intomodrinth:masterfrom
n1ckoates wants to merge 1 commit intomodrinth:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request disables CSS transitions when changing the theme, by temporarily adding a
<style>tag to<head>that overrides transitions. This prevents an "unsynced" theme transition, where different elements change their colors in different ways, which looks weird for the end user.This is best shown on
/settings, where the background of dropdowns and the thumb of switch toggles transition slower than the page background.