Repository navigation
Conversation
|
PR author is not in the allowed authors list. |
|
@nickryand is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
squad-joey
left a comment
There was a problem hiding this comment.
Two test issues need attention at b4c3e224:
- The added test breaks typecheck.
tsc --noEmitpasses on based8cd77bb, but head reports TS2339 atcredentials.test.ts:53:HUNK_RUNTIME_DIRdoesn't exist on the inferred return type ofisolatedEnv(). Give the helper or its result an explicitNodeJS.ProcessEnvtype. - The credential fixtures inherit the new override.
isolatedEnv()spreadsprocess.envand sets onlyXDG_RUNTIME_DIR. WithHUNK_RUNTIME_DIRalready set, credentials are now created in that inherited directory rather than the temporary fixture. Using a synthetic ambient directory, the same credential test command passes all 4 tests on base but produces 2 passes / 3 failures on head: missing expected XDG files and a symlink-rejection test that unexpectedly resolves. Please clear the inherited override in the helper; the new precedence test can then set its own override explicitly.
A local, test-only experiment adding the return type and HUNK_RUNTIME_DIR: undefined to the helper made typecheck and all 5 credential tests pass with that synthetic ambient override. I restored the reviewed checkout afterward. This doesn't establish isolation for every other test helper that copies the environment.
The runtime selection itself behaved as intended in my checks: head uses the nonblank Hunk override ahead of XDG, while base ignores it; blank values fall back. Separately launched source daemons and authenticated session list clients agreed on the selected credential store.
Validation scope
- Exact base
d8cd77bbfc053bedbeeb049207effcd4ba86039c→ headb4c3e224ace4f3fc40eace7b6d13e93fc47eac83; Linux x86_64, Bun 1.4.2, Node 24.14.1, frozen dependencies without lifecycle scripts. - Independent matrix: 14 cases per revision, covering default/XDG/override precedence, empty/blank/trimmed values, paths with spaces and relative paths, invalid directory, symlinked namespace, unsafe credential mode, and two actual daemon/CLI agreement cases. Only synthetic credential stores were used.
- Unmodified focused credential/launcher/config/daemon tests: base 36 pass, head 37 pass, with no ambient override. Head's dedicated real-Node broker suite: 4 pass.
- No full-suite, PTY interaction, installed-binary, macOS or Windows verification. The unmodified head's typecheck remains failing as described above.
This comment was generated by Pi using GPT-6.1 Sol
Summary
Allow users to choose where Hunk stores session runtime state and credentials with HUNK_RUNTIME_DIR. Hunk uses XDG_RUNTIME_DIR when the override is unset, then falls back to its existing default. This allows for the customization of the hunk runtime directory without affecting any other tools that use XDG_RUNTIME_DIR.
This belongs in core because it configures shared session-broker runtime behavior, not an optional extension workflow. No other behavior is intentionally changed.