Repository navigation
fix(ui): distinguish empty reviews from filtered files - #1182
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
benvinegar
marked this pull request as ready for review
October 13, 2026 18:17
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1180.
A clean worktree or empty patch currently says “No files match the current filter” even with no active filter. Show “No changes to review.” for empty loaded input; retain the existing filter message when a nonempty review has no visible files.
Approach
Appalready owns the unfiltered review and its visible projection, so it selects the presentation-only empty-state message.DiffPanerenders that message rather than inferring why its projected file list is empty.Tests
main; the existing active-filter behavior remains covered.Validation on Linux:
bun run typecheck— passed.bun run lint— passed.bun run format:check— passed.bun run deps:check— passed.bun run test— 5,080 passed, 13 skipped, no failures.bun test test/pty/empty-review-integration.test.ts— 3 passed.bun run test:integration— 259 passed, 1 skipped, no failures.bun run test:tty-smoke— 11 passed, no failures.CI follow-up
Added a separate test-only commit to address CI failures:
main(6aa52617, Website run). StableLatestand release ordering/link assertions remain intact. All 103 browser smoke tests passed locally (1 skipped).No product behavior, generated release metadata or workflow gating changes are included in this follow-up. The identical test-only commit is also on #1183 so both independent PRs can pass CI.
Real terminal evidence
Ran source
hunk diff --no-extensionson a clean disposable worktree andhunk patch --no-extensionswith empty file-backed stdin in real tmux PTYs: Linux, 120×32, default terminal theme/auto layout. The corresponding new PTY tests also exercise a 60×12 resize and keyboard filtering/recovery.Actual tmux screen text (not redirected CLI stdout):
No mouse action changes. macOS and Windows not tested locally. The installed npm beta and existing user sessions were left untouched.
This PR description was generated by Pi using gpt-6.1-sol