Skip to content

perf(ci): focus Windows compatibility tests - #1074

Merged
benvinegar merged 1 commit into
mainfrom
ci/focused-windows-tests
Sep 9, 2026
Merged

benvinegar merged 1 commit into
mainfrom
ci/focused-windows-tests

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • keep Windows coverage focused on platform, process, VCS, CLI, session, and packaging boundaries
  • leave the platform-neutral terminal UI semantic suite on Linux
  • retain focused Windows UI boundary coverage for worker startup, editor commands, and workspace path safety
  • document and test the new named runner groups

Why

The full Windows suite repeated 4,191 tests across 373 files and spent 3m57s in the test step. The terminal UI tree alone accounted for about 1m48s while exercising semantics already covered by Linux CI.

This keeps one serial Bun process on Windows and does not change the required Windows compatibility check. It removes duplicated platform-neutral UI coverage rather than introducing concurrent processes or timer contention.

Validation

  • HUNK_TEST_SHARDS=1 bun run test:windows — 2,669 tests plus 31 focused UI boundary tests passed
  • bun run test — passed
  • bun test scripts/test/run-test-suite.test.ts — 9 passed, 35 assertions
  • bun run typecheck
  • bun run lint
  • changed-file formatting and diff checks
  • workflow YAML parsing

This PR description was generated by Pi using GPT-5.6 Sol

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
hunk-web Ignored Ignored Sep 9, 2026 2:30pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR reduces duplicate Windows CI work while preserving the existing required compatibility check.

  • Introduces named windows and windows-ui runner groups.
  • Excludes the platform-neutral terminal UI tree from the broad Windows suite.
  • Retains focused Windows coverage for worker startup, editor commands, and workspace path safety.
  • Documents and unit-tests group resolution and runner arguments.

Confidence Score: 5/5

The PR appears safe to merge, with the intended Windows coverage boundaries preserved by focused tests.

The new groups resolve to the expected patterns and arguments, execute serially under the current Windows workflow, and retain the identified platform-sensitive UI coverage.

Important Files Changed

Filename Overview
scripts/test/run-test-suite.ts Adds named Windows groups and injects the UI-tree exclusion into only the broad Windows invocation.
scripts/test/run-test-suite.test.ts Verifies Windows group selection, runner arguments, explicit test patterns, and unknown-group rejection.
package.json Adds a sequential command that runs the broad Windows suite followed by focused UI boundary tests.
.github/workflows/pr-ci.yml Changes the required Windows compatibility job from the complete suite to the focused Windows command.
test/README.md Documents the ownership split between Linux UI semantics and Windows-specific UI boundaries.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    CI[Windows compatibility job] --> Script[bun run test:windows]
    Script --> Platform[windows group]
    Script --> UI[windows-ui group]
    Platform --> Broad[Packages, scripts, examples, CLI, sessions]
    Platform --> Exclude[Exclude terminal UI tree]
    UI --> Worker[Worker startup]
    UI --> Editor[Editor commands]
    UI --> Paths[Workspace path safety]
Loading

Reviews (1): Last reviewed commit: "perf(ci): focus Windows compatibility te..." | Re-trigger Greptile

@benvinegar
benvinegar merged commit 3736205 into main Sep 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant