Repository navigation
perf(ci): focus Windows compatibility tests - #1074
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR reduces duplicate Windows CI work while preserving the existing required compatibility check.
Confidence Score: 5/5The PR appears safe to merge, with the intended Windows coverage boundaries preserved by focused tests. The new groups resolve to the expected patterns and arguments, execute serially under the current Windows workflow, and retain the identified platform-sensitive UI coverage. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CI[Windows compatibility job] --> Script[bun run test:windows]
Script --> Platform[windows group]
Script --> UI[windows-ui group]
Platform --> Broad[Packages, scripts, examples, CLI, sessions]
Platform --> Exclude[Exclude terminal UI tree]
UI --> Worker[Worker startup]
UI --> Editor[Editor commands]
UI --> Paths[Workspace path safety]
Reviews (1): Last reviewed commit: "perf(ci): focus Windows compatibility te..." | Re-trigger Greptile |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The full Windows suite repeated 4,191 tests across 373 files and spent 3m57s in the test step. The terminal UI tree alone accounted for about 1m48s while exercising semantics already covered by Linux CI.
This keeps one serial Bun process on Windows and does not change the required
Windows compatibilitycheck. It removes duplicated platform-neutral UI coverage rather than introducing concurrent processes or timer contention.Validation
HUNK_TEST_SHARDS=1 bun run test:windows— 2,669 tests plus 31 focused UI boundary tests passedbun run test— passedbun test scripts/test/run-test-suite.test.ts— 9 passed, 35 assertionsbun run typecheckbun run lintThis PR description was generated by Pi using GPT-5.6 Sol