Skip to content

feat: add sorting to model detail recipe lists - #47

Merged
cattan0710-tech merged 4 commits into
mainfrom
codex/model-recipe-sorting-20261110
Nov 10, 2026
Merged

cattan0710-tech merged 4 commits into
mainfrom
codex/model-recipe-sorting-20261110

Conversation

@cattan0710-tech

@cattan0710-tech cattan0710-tech commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Model detail pages now offer the same sorting control as the catalog: throughput improvement (default), recipe name A–Z/Z–A, and newest release date. The selected order is stored in the URL and survives refresh and back/forward navigation while preserving catalog return context and explicitly pinned snapshots.

Shares the sorting control and URL value validation with the catalog, fixes reverse ordering of recipe names within a model, and wraps the section header on narrow screens. Recipes without improvement or release-date data remain last.

Validation:

  • All 196 unit tests passed, including new regressions for same-model name sorting, ties, zero/missing gains, missing dates, and invalid URL values.
  • TypeScript, targeted ESLint, Prettier, and git diff checks passed.
  • Playwright coverage at 390px and 1440px verifies all orders, refresh, history navigation, pinned snapshots, return links, and horizontal overflow. These tests and report retry coverage passed three consecutive local browser runs (9/9).
  • Fixtures validate recipe IDs against YAML/history paths and bind tuning records to explicit recipe versions. Report retry mocking stays unavailable until the user retries, including redirect remounts.
  • GitHub CI is rerunning after the test fixture fixes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T12:47:35.834070Z cdbdfb6 PR opened
🔒 Security Review ✅ Completed 2026-11-10T12:48:31.060639Z cdbdfb6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cdbdfb6001

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +13 to +16
{ ...template, id: 'alpha', releaseDate: '2026-11-10' },
{ ...template, id: 'bravo', releaseDate: '2026-10-01' },
{ ...template, id: 'charlie', releaseDate: undefined },
{ ...template, id: 'delta', releaseDate: '2026-11-01' },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update fixture paths to match the renamed recipe IDs

Both new Playwright cases serve variants whose IDs are alpha, bravo, etc., but whose path and history still reference the original template ID. When the app fetches this fixture, loadCatalog() calls parseCatalog(), which explicitly rejects paths that do not match the model and variant IDs. The app therefore retains the baseline catalog instead of rendering the four test recipes, and both cases time out looking for the expected section. Set each variant's path and history to match its new ID before fulfilling the catalog request.

Useful? React with 👍 / 👎.

@cattan0710-tech
cattan0710-tech merged commit 31eeb05 into main Nov 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant