Repository navigation
feat: add sorting to model detail recipe lists - #47
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdbdfb6001
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { ...template, id: 'alpha', releaseDate: '2026-11-10' }, | ||
| { ...template, id: 'bravo', releaseDate: '2026-10-01' }, | ||
| { ...template, id: 'charlie', releaseDate: undefined }, | ||
| { ...template, id: 'delta', releaseDate: '2026-11-01' }, |
There was a problem hiding this comment.
Update fixture paths to match the renamed recipe IDs
Both new Playwright cases serve variants whose IDs are alpha, bravo, etc., but whose path and history still reference the original template ID. When the app fetches this fixture, loadCatalog() calls parseCatalog(), which explicitly rejects paths that do not match the model and variant IDs. The app therefore retains the baseline catalog instead of rendering the four test recipes, and both cases time out looking for the expected section. Set each variant's path and history to match its new ID before fulfilling the catalog request.
Useful? React with 👍 / 👎.
Model detail pages now offer the same sorting control as the catalog: throughput improvement (default), recipe name A–Z/Z–A, and newest release date. The selected order is stored in the URL and survives refresh and back/forward navigation while preserving catalog return context and explicitly pinned snapshots.
Shares the sorting control and URL value validation with the catalog, fixes reverse ordering of recipe names within a model, and wraps the section header on narrow screens. Recipes without improvement or release-date data remain last.
Validation: