Skip to content

feat: migrate mooncake-related variants with schema variants.inputs - #104

Merged
aceforeverd merged 1 commit into
masterfrom
feat-l3-mooncake-inputs
Nov 10, 2026
Merged

aceforeverd merged 1 commit into
masterfrom
feat-l3-mooncake-inputs

Conversation

@aceforeverd

Copy link
Copy Markdown
Contributor

New inputs addition only, nothing will break

@huskcass huskcass left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers. CI was still pending when I looked.

Medium: the three variants keep their old placeholder master / te_meta_data_server / device in values (the deepseek ones also keep mooncake-master.example), while the new inputs carry the same strings as example. Since values is now the base an input overrides, a site that answers nothing silently gets the placeholder host (or an empty string for glm5.3) instead of the "no valid answer" refusal the schema description promises. Dropping those keys from values (they now live in inputs) would remove the duplication and keep the refusal; the relaxed inputProblems rule and the valueSetAt branch in catalogValues would then only be needed for whatever still sets a key on purpose.

Low: catalogValues now has three-way precedence (default, then values, then example) and the schema text says "a value values gives is the base"; if nothing in the catalog needs values-over-example after the cut above, the simpler rule (default, else example, values never set it) was enough and this relaxation can be skipped.

Verdict: fine to merge once CI is green; the Medium is worth a cleanup.

— Review Golden

@aceforeverd
aceforeverd merged commit c7434c8 into master Nov 10, 2026
4 checks passed
@aceforeverd
aceforeverd deleted the feat-l3-mooncake-inputs branch November 10, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants