Repository navigation
test(e2e): check the RouteStuck event instead of the transient status - #22
Merged
Merged
Conversation
aceforeverd
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main-branch E2E run 40069498015 failed "reaches RouteStuck when the route finalizer is never cleared".
The controller behaved correctly: it set
status.deletion.outcome=RouteStuckand emitted a WarningRouteStuckevent, then, in the same second, uninstalled the release, released the service and dropped its finalizer (the chart has no pods to wait on). The spec polledstatus.deletion.outcomewith kubectl every 200ms, missed the sub-second window in which the object still existed, and timed out.Fix: assert on the
RouteStuckevent instead, the same way the force-delete spec checksPodForceDeleted. Events outlive the object (default TTL 1h), so the check no longer races the release. The follow-up checks (service gone, ModelRoute finalizer still present) are unchanged.Also:
eventsContainnow filters oninvolvedObject.kind=LLMServiceas well as the name; both callers look for events on the LLMService.deletionOutcomeis removed, as it has no remaining callers.