Repository navigation
chore(llm-slo-decision-gen): bump slo-api to 0.3.0 - #97
Merged
Merged
Conversation
slo-api 0.3.0 serves JobSLORequirement routes and accepts the pdengine bound type and bound value 0, which the chart's CRDs already allow. The README's slo-api rows still described v0.1 as unusable; slo-api has been on by default since the 0.2.0 image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
Moves the chart's slo-api image to 0.3.0. That release:
JobSLORequirementroutes,pdenginebound type (feat(llm-slo-decision-gen): add pdengine bound type to LLMSLORequirement CRD #95),Before this, the chart shipped CRDs that allow all three while slo-api 0.2.0 refused them. The slo-api ClusterRole already grants
jobslorequirements, so no RBAC change is needed.values.yaml:sloApi.image.taggoes from0.2.0to0.3.0, and the comment says what 0.3.0 adds.Chart.yaml:versiongoes from 0.3.7 to 0.3.8.appVersionstays at decision-gen's 0.8.0.README.md: the two slo-api rows still saidv0.1/ "do not enable". slo-api has been on by default since the 0.2.0 image, so the rows now describe what the chart renders.Which issue(s) this PR fixes
Refs modelsphere/slo-api#8, modelsphere/slo-api#9
How it was tested
helm lint --strict charts/llm-slo-decision-gen→1 chart(s) linted, 0 chart(s) failedhelm template ci charts/llm-slo-decision-gen | grep llm-slo-api:→image: "4pdosc/llm-slo-api:0.3.0"hack/check-chart-version.sh origin/main→ exit 04pdosc/llm-slo-api:0.3.0is on Docker Hub (amd64, arm64), published by the release run.check-chart-images.shruns in CI becausecraneis not installed locally.Checks
🤖 Generated with Claude Code