Repository navigation
sglang 0.9.18, vllm 0.8.17: pd router boot script logs identity + handoff - #73
Merged
Merged
Conversation
…doff Otherwise the container log shows a quiet gap between the "router: prefill / router: decode" argv line and vllm-router's own first line, with no indication that probe_identity ran (or hung) between them. Three breadcrumbs, stdout-safe: - per-IP success: "router: <ip> identity <restarts>|<ts>" - per-IP sentinel: "router: <ip> identity sentinel (...reason...)" - handoff to exec: "router: boot script done, exec into router" All three go to stderr so they land in the container log; stdout stays reserved for probe_identity's return value. Sentinel reasons disambiguate the three no-identity paths (hangWatcher disabled at render, sidecar has no /engine, 90min budget exhausted).
The prior commit's subject still references 0.9.18 / 0.8.17, but those versions belong to #72 (the engine-identity drift probe). This bump re-attaches the log-lines change to its own version pair so the followup release can be tagged cleanly. No template / values change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The router boot script from #72 runs a silent gap between the argv line (
router: prefill .../router: decode ...) and the router process actually starting — during whichprobe_identitymay be querying sidecars, writing the snapshot file, or (worst case) stuck on the 90-minute budget.kl logson a router pod showed nothing between those two moments, which made it hard to tell whether boot was progressing or wedged.Three breadcrumbs added, all on stderr so
probe_identity's stdout return value stays clean:Sentinel reasons disambiguate the three no-identity paths:
hangWatcher disabled at render—HW_PORT=0sidecar has no /engine— 404 from an older sidecar90min budget exhaustedline (unchanged) covers the third case.Rendered-output change
Only the boot-script body changes — adds the
echo >&2lines, no behavior change. Affects both charts' pd-ds DisaggregatedSet router Deployment. 52 non-pd cases unchanged.Gold rebaked per R3 at this branch's HEAD; 54/54 verify.
Test plan
helm templaterenders clean for all pd cases, both chartsbash -non the extracted boot scriptskl logs <router-pod>on a pd render shows the three breadcrumbs in order (argv line → per-IP identity/sentinel → handoff → router's own first log)🤖 Generated with Claude Code