Repository navigation
feat(web): select model catalogs per canary arm - #99
Merged
aceforeverd merged 1 commit intoOct 25, 2026
Merged
Conversation
Read v2 catalogs from Swiss cluster configuration, default to upstreamv2, and scope model, variant and chart selection to each arm catalog. Reset source-specific configuration when switching catalogs.
huskcass
reviewed
Oct 25, 2026
huskcass
left a comment
Collaborator
There was a problem hiding this comment.
No blockers at 8dea0fd.
Verdict: per-arm catalog selection is wired end to end (Swiss /cluster and named /catalog, chart-versions and prepare all carry the arm's catalog) and the reset on catalog change is correct; typecheck and web tests pass.
— Review Golden
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
Canary arms previously listed models from the default catalog only. Each arm now chooses its own model catalog before choosing a model and variant, using the existing authenticated Swiss
/clusterand named/catalogendpoints.upstreamv2when configured, otherwise a supported environment default or first supported catalog.Which issue(s) this PR fixes
Fixes #98
How it was tested
npm run typecheck,npm test(485 tests / 58 files),npm run build.go test ./...,go vet ./...,gofmtandgit diff --check.upstreamv2andinnerreturned 201. Frozen Swiss plans retain the two distinct catalog names and variants; GPU models were prepared only.Checks
go test ./...andgofmt -l .is emptynpm run typecheck && npm test && npm run buildinweb/Notes for reviewers
Base is
release-canary, which contains the Canary module. This PR contains only catalog selection. The test deployment also retains the existing environment-default wizard changes from #97; those changes are not included in this diff.Start with
CanaryCreate.tsx, then the authenticated catalog transport and reset/default tests. No backend API, config key or CRD changes.Release note