Repository navigation
feat(inferences): show uninstalling deployments and block writes on them - #96
Merged
Merged
Conversation
swiss keeps an uninstalled release listed with phase uninstalling until its pods are gone, and reports an LLMService with a deletionTimestamp the same way. Show that state in the list and detail of both front-ends, and disable Uninstall, Upgrade/Edit, rollback and SLO edit while it lasts. Closes #94
huskcass
commented
Oct 23, 2026
huskcass
left a comment
Collaborator
Author
There was a problem hiding this comment.
No blockers.
Verdict: good to merge alongside modelsphere/swiss#31. The single phase helper, the disabled actions and the component tests cover both front-ends, and nothing changes against an older swissd.
— Review Golden
aceforeverd
approved these changes
Oct 25, 2026
aceforeverd
pushed a commit
that referenced
this pull request
Oct 25, 2026
…hem (#96) swiss keeps an uninstalled release listed with phase uninstalling until its pods are gone, and reports an LLMService with a deletionTimestamp the same way. Show that state in the list and detail of both front-ends, and disable Uninstall, Upgrade/Edit, rollback and SLO edit while it lasts. Closes #94 Co-authored-by: huskcass <333684917+huskcass@users.noreply.github.com>
5 of 6 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
A deployment from the swiss plan (helm backend) disappeared from the list right after Uninstall, even though its pods kept terminating for a while. modelsphere/swiss#31 now keeps that row listed with
phase: uninstallinguntil the resources are gone. It also reports an LLMService with a deletionTimestamp the same way. This PR shows that state in the UI and turns off the actions that would now get a 409.isUninstalling()helper (web/src/modules/swiss/lib/phase.ts) checks the rowphase, helmstatus/helmStatus,planStatus.phaseandllmservice.phase. It takes precedence over failed, applying, not installed and no pods.uninstallingbadge and disables Uninstall, Upgrade and Roll back.Which issue(s) this PR fixes
Closes #94
How it was tested
uninstalling. Component tests render the list and detail of both front-ends with an uninstalling deployment and a serving one, and assert the label and the disabled or enabled actions.npm run typecheck,npm test(47 files, 418 tests),npm run buildandnpm run build:swisspass, as dogofmt -l .(empty),go vet ./...andgo test ./....Checks
go test ./...andgofmt -l .is emptynpm run typecheck && npm test && npm run buildinweb/Release note