Repository navigation
Conversation
imneov
force-pushed
the
fix/66-upgrade-current-values
branch
from
October 26, 2026 16:59
99221af to
3c9edcf
Compare
imneov
marked this pull request as draft
November 7, 2026 15:49
imneov
force-pushed
the
fix/66-upgrade-current-values
branch
from
November 7, 2026 15:50
3c9edcf to
57a4be9
Compare
imneov
marked this pull request as ready for review
November 8, 2026 03:24
imneov
force-pushed
the
fix/66-upgrade-current-values
branch
from
November 8, 2026 05:52
a71d21c to
0cfe0ad
Compare
Keep existing form/edit persistence, synchronized editing and server previews. Record verification as text without committing binary artifacts. Fixes modelsphere#66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
Deploy and upgrade controls and YAML can show different values, and the upgrade YAML editor can start empty. This change shares the editing model between both views while keeping the existing form/edit persistence rules.
The form's Edit YAML action opens three panes: read-only deployment baseline, editable user YAML, and read-only server-composed effective configuration. Changing
replicaCountfrom 2 to 3 in YAML updates the form to 3; changing it in the form updates YAML. Pasting only an image override retains the previously saved form replica count.overrides,editsYAML, plan/diff/apply and dry-run APIs. No backend change, new capability or deployment-service upgrade is required.Which issue(s) this PR fixes
Fixes #66.
How it was tested
go vet ./...,go test ./...andgit diff --checkpassed.Browser checks use fixture data. Live deployment and interruption/recovery were not performed. Full verification:
docs/plans/2026-11-07-deployment-configuration-checks.md.Checks
Notes for reviewers
Start with
deployment-draft.ts,use-deployment-draft.tsanddeployment-preview.ts, thendeployment-gpu.ts,use-deployment-values.tsand the components. Model library/detail deployment and service list/detail upgrade shareDeploySheet.Design:
docs/plans/2026-11-07-deployment-configuration.md. Existing API semantics:docs/plans/2026-11-07-deployment-values-contract.md.Release note