Skip to content

feat(web): rich-featured edit YAML overrides - #117

Merged
aceforeverd merged 2 commits into
modelsphere:mainfrom
imneov:feat/deploy-yaml-review
Nov 6, 2026
Merged

aceforeverd merged 2 commits into
modelsphere:mainfrom
imneov:feat/deploy-yaml-review

Conversation

@imneov

@imneov imneov commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • feature

What this PR does and why

The final deploy/upgrade review only displays the plan and dry-run output. Add Edit YAML to populate an editor with the composed deployment values, following Rise Global's deployment drawer.

Saving validates the YAML, preserves existing overrides, and records only changed values. It then recomposes the plan, checks that the resulting values match the edited YAML, and runs a fresh diff before deployment is enabled. Invalid drafts remain visible, and background defaults refreshes cannot discard them.

Which issue(s) this PR fixes

Fixes #116

How it was tested

  • pnpm --dir web run typecheck — passed for both console and standalone Swiss configurations.
  • pnpm --dir web test — 57 test files, 521 tests passed, including 16 deployment YAML tests covering layer order, existing edits, nested changes, removals, invalid documents, upgrade identity, and composition drift.
  • pnpm --dir web run build — passed.
  • Browser check with the real editor component: populated YAML is editable, syntax errors block saving, and changing replica count submits only the corresponding override.
  • A live backend deployment was not exercised: the available console session could not log in.

Checks

  • Web typecheck, tests, and production build
  • Docs updated where behaviour moved
  • No internal hostnames, IPs, registries or credentials
  • Go and Helm checks are not applicable; no Go or chart files changed.

Notes for reviewers

Start with deploy-yaml.ts for merge/override semantics and DeploySheet.tsx for plan/diff gating. YAML edits use the existing plan API; no API, permission, or CRD changes are required.

Release note

Deployment and upgrade review now offer a populated YAML editor, with validation and a fresh change preview before applying edits.

@imneov
imneov force-pushed the feat/deploy-yaml-review branch from 2c047e1 to 7e03f1a Compare November 5, 2026 14:41
Populate the review editor from composed values, retain only changed overrides, and require a fresh verified plan and diff before applying.

Fixes modelsphere#116
@aceforeverd

aceforeverd commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

edit yaml in Post-Compose , where the plan already constructed, is not the right place to edit install values again. Reworking

@aceforeverd
aceforeverd force-pushed the feat/deploy-yaml-review branch from 7e03f1a to d0c037d Compare November 6, 2026 10:17
@aceforeverd aceforeverd changed the title feat(web): edit deployment YAML during final review feat(web): rich-featured edit YAML overrides Nov 6, 2026
@aceforeverd
aceforeverd merged commit abb4a07 into modelsphere:main Nov 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inferences: deployment review has no populated YAML editor

2 participants