Repository navigation
feat(web): rich-featured edit YAML overrides - #117
Merged
Merged
Conversation
imneov
force-pushed
the
feat/deploy-yaml-review
branch
from
November 5, 2026 14:41
2c047e1 to
7e03f1a
Compare
Populate the review editor from composed values, retain only changed overrides, and require a fresh verified plan and diff before applying. Fixes modelsphere#116
Contributor
|
edit yaml in Post-Compose , where the plan already constructed, is not the right place to edit install values again. Reworking |
aceforeverd
force-pushed
the
feat/deploy-yaml-review
branch
from
November 6, 2026 10:17
7e03f1a to
d0c037d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
The final deploy/upgrade review only displays the plan and dry-run output. Add Edit YAML to populate an editor with the composed deployment values, following Rise Global's deployment drawer.
Saving validates the YAML, preserves existing overrides, and records only changed values. It then recomposes the plan, checks that the resulting values match the edited YAML, and runs a fresh diff before deployment is enabled. Invalid drafts remain visible, and background defaults refreshes cannot discard them.
Which issue(s) this PR fixes
Fixes #116
How it was tested
pnpm --dir web run typecheck— passed for both console and standalone Swiss configurations.pnpm --dir web test— 57 test files, 521 tests passed, including 16 deployment YAML tests covering layer order, existing edits, nested changes, removals, invalid documents, upgrade identity, and composition drift.pnpm --dir web run build— passed.Checks
Notes for reviewers
Start with
deploy-yaml.tsfor merge/override semantics andDeploySheet.tsxfor plan/diff gating. YAML edits use the existing plan API; no API, permission, or CRD changes are required.Release note