Repository navigation
Conversation
The Scaling card and both install-status scaler steps treated any False condition as failing. ScalingDeferred=False/NotDeferred is the normal state, so every healthy scaler showed as broken. One helper, scalerHealth, now decides for all three: - With a Ready condition (modelsphere/llm-operator#23), Ready=False is failing with its reason. - Without one (older operators), only DecisionAvailable=False is failing. ScalingDeferred=False is never a failure. - ScalingDeferred=True is a waiting state with its reason. - Otherwise the current/desired comparison applies as before. The Scaling card also shows lastScaleTime and a stale-generation note from status.observedGeneration. Co-authored-by: aceforeverd <11715200+aceforeverd@users.noreply.github.com>
The operator replaces ScalingDeferred with an HPA-style AbleToScale condition where True is normal. Treat AbleToScale=False as failing and AbleToScale=True with RolloutInProgress or ScaleDownSettling as a hold. Operators that still report ScalingDeferred keep the previous fallback. Co-authored-by: aceforeverd <11715200+aceforeverd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
The Scaling card (
ReleaseObjects.tsx) and the scaler step in both install-status views (inferences/lib.ts,swiss/routes/DeploymentDetail.tsx) marked a scaler as failing if any of its conditions wasFalse.ScalingDeferred=Falsewith reasonNotDeferredis the normal state, so every healthy scaler showedNotDeferredas a warning or a bad step.modelsphere/llm-operator#23 adds a summary
Readycondition,status.observedGenerationandstatus.lastScaleTime, in the style of HPA v2 and KEDA. It also replacesScalingDeferredwith an HPA-styleAbleToScalecondition, where True is normal:Synced, a hold reason (RolloutInProgress,ScaleDownSettling) orDeferralTimedOut. False means the target cannot be scaled (InvalidSpec,TargetNotFound,TargetUnreadable,TargetWriteFailed).All three places now go through one helper,
scalerHealthinweb/src/modules/swiss/lib/scaler.ts:Ready/AbleToScaleReady=FalseorAbleToScale=False, shown with its reason (Readyfirst)AbleToScale=TruewithRolloutInProgressorScaleDownSettling:deferred: <reason>ScalingDeferredDecisionAvailable=FalseScalingDeferred=True:deferred: <reason>ScalingDeferred=False(NotDeferred,DeferralTimedOut) from older operators is never treated as a failure. WhenAbleToScaleis present, a leftoverScalingDeferredis ignored.Also:
LLMScalerStatusgainsappliedReplicas,observedGeneration,lastScaleTimeanddeferredSince.lastScaleTimeis set. It also shows the stale-generation note fromobservedGeneration, the same note the route panel uses.scaler.deferredin en-US and zh-CN.Which issue(s) this PR fixes
Refs modelsphere/llm-operator#23
How it was tested
scaler.test.ts: table-drivenscalerHealthcases coveringAbleToScale(each hold reason,Synced,DeferralTimedOut, False, precedence againstReady) and older operators withScalingDeferred, includingNotDeferredreading as ok.lib.test.ts:installStepswithNotDeferredis steady,Ready=Falseis bad, andScalingDeferred=Trueis waiting.Checks
npm run typecheck && npm test && npm run buildinweb/(48 files, 437 tests)Release note