Repository navigation
Release 0.6.6 - #5
Merged
Merged
Conversation
Cargo.toml still said 0.6.4, so the 0.6.5 image reported 0.6.4 from --version. 0.6.6 is the first release with linux/arm64 images (#4).
The tag names the image, Cargo.toml the version the binary reports from --version, and nothing kept them together: v0.6.5 was released with Cargo.toml at 0.6.4. On a tag push, fail before building unless the tag (its core, for a prerelease such as v0.6.6-rc1) equals the [package] version in Cargo.toml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the version to 0.6.6 so the
v0.6.6tag can be cut, and stop the tag and Cargo.toml from drifting apart again.--version. 0.6.6 is the first release with linux/arm64 images (Publish the image for linux/arm64 as well as linux/amd64 #4).[package]version in Cargo.toml. A prerelease tag (v0.6.6-rc1) is compared by its core version.Checked the step's script against real commits:
v0.6.5andv0.6.6-rc1(Cargo.toml 0.6.4) fail;v0.6.6andv0.6.6-rc2on this branch pass;v0.6.7on this branch fails.