[megatron] support save_total_limit

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the MegatronArguments configuration by adding a new parameter, save_total_limit. This addition provides users with the ability to specify a maximum number of checkpoints or models to retain, which helps in managing storage resources by automatically pruning older saved states.

Highlights

• New Argument Added: Introduced save_total_limit: Optional[int] = None to the MegatronArguments class, enabling control over the number of saved checkpoints.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• swift/megatron/arguments/megatron_args.py
  • Added save_total_limit argument to the MegatronArguments class.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the save_total_limit argument to MegatronArguments. However, the core logic to limit the number of saved checkpoints based on this argument appears to be missing, as indicated by a TODO in swift/megatron/utils/megatron_lm_utils.py. For the feature to be complete, the checkpoint rotation logic needs to be implemented. Without it, this PR only adds an unused argument.

[gemini-code-assist]

While the save_total_limit argument is added here, the corresponding implementation to manage and limit the number of saved checkpoints is missing. A TODO in swift/megatron/utils/megatron_lm_utils.py indicates this is a planned feature. To make this functional, logic for deleting older checkpoints needs to be added.