Update to Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator#2
Open
modelonrobinandersson wants to merge 4 commits intomaint/3.2.3from
Open
Update to Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator#2modelonrobinandersson wants to merge 4 commits intomaint/3.2.3from
modelonrobinandersson wants to merge 4 commits intomaint/3.2.3from
Conversation
…elica#3410) * Update to Modelica.Magnetic.FluxTubes.Examples.Hysteresis.SinglePhaseTransformerWithHysteresis1 In order to setup the initial equation system to Modelica.Magnetic.FluxTubes.Examples.Hysteresis.SinglePhaseTransformerWithHysteresis1 additional equations are needed in order to obtain a balanced system. That the equations below are added is natural as a consequence of the start values and fixed=true for these states: ``` winding1.i = 0; winding2.i = 0; core.MagRel = 0.5; ``` However, the fourth equation that is needed is not clearly defined, and different compiler heuristics will lead to different initial equations. We suggest to explicitly add ``` initial equation core.derHstat = 0.0; ``` * Fix single phase hysteresis transformer example * Fix initial conditions of HysteresisModelComparison * Fix initial conditions of three phase hysteresis transformer model Plus remove protected to allow access to the transformer components from outside the model Co-authored-by: Christian Kral <dr.christian.kral@gmail.com>
maint/3.2.3: Fix mass flow rate calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue modelica#3417