R134a example medium

[thorade]

it might be nice to add R134a as predefined medium, because it also exists in MSL so it can be used for comparison and benchmarking

Summary by CodeRabbit

• New Features
  • Added three new example packages for modeling refrigerant R-134a with CoolProp, including standard, bicubic interpolation, and TTSE interpolation options.

[casella]

@thorade sorry for not giving you feedback earlier. This sounds good, maybe we could also add the native (non-tabular) medium definition?

[thorade]

@casella Sure, I added that as well now.

[coderabbitai]

Walkthrough

This update adds three new packages to the Modelica/ExternalMedia/Examples.mo file. The packages R134aCoolProp, R134aCoolPropBicubic, and R134aCoolPropTaylor implement CoolProp models for the refrigerant R-134a. They extend ExternalMedia.Media.CoolPropMedium and differ by interpolation methods and substance name modifiers.

Changes

File	Change Summary
Modelica/ExternalMedia/Examples.mo	Added three new packages: R134aCoolProp (standard CoolProp model), R134aCoolPropBicubic (tabulated data with bicubic interpolation), and R134aCoolPropTaylor (tabulated with TTSE interpolation flag). All extend ExternalMedia.Media.CoolPropMedium.

Sequence Diagram(s)

sequenceDiagram
    participant SE as Simulation Engine
    participant RCP as R134aCoolProp
    participant RCPB as R134aCoolPropBicubic
    participant RCPT as R134aCoolPropTaylor
    participant Base as ExternalMedia.Media.CoolPropMedium

    SE->>RCP: Instantiate R134aCoolProp model
    RCP->>Base: Inherit initialization & properties (standard data)

    SE->>RCPB: Instantiate R134aCoolPropBicubic model
    RCPB->>Base: Inherit initialization & properties (tabulated data with bicubic interpolation)

    SE->>RCPT: Instantiate R134aCoolPropTaylor model
    RCPT->>Base: Inherit initialization & properties (tabulated data with TTSE interpolation flag)

Loading

Poem

I’m a rabbit hopping with glee,
Three new models join the spree!
R134a in CoolProp’s light,
Bicubic, Taylor — all just right.
Codes and hops in harmony,
A joyful leap in modeling spree! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91d569a and 53d0602.

📒 Files selected for processing (1)

• Modelica/ExternalMedia/Examples.mo (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Modelica/ExternalMedia/Examples.mo

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[thorade]

I added one more example, so now there are three variants of R134a.
This could probably be merged any time now.

[thorade]

@casella and @jowr
Could this small PR also be merged before the next release?