[codex] Improve filesystem startup directory diagnostics#4278
Draft
tarunag10 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves filesystem server startup diagnostics for invalid allowed-directory arguments.
The current source already skips invalid directories and only exits when none of the specified directories are accessible, which matches the behavior requested in #4238. However, the stderr warnings for inaccessible paths were still generic and the hard-fail path did not list the invalid arguments or their concrete failure reasons. In host environments that hide or truncate child-process stderr, every extra bit of actionable startup output matters.
Root Cause / User Impact
A missing or invalid allowed directory can be difficult to diagnose from a host-level "transport closed" failure. The current startup validation says that a directory cannot be accessed, but it drops the underlying error message such as
ENOENT, and when all directories are invalid it exits without enumerating the failed inputs.Fix
Skipping invalid allowed directoryformat that includes the directory and reason.ENOENT, and that all-invalid startup reports each failed directory.Validation
npm cinpm run build --workspace @modelcontextprotocol/server-filesystemnpx vitest run src/filesystem/__tests__/startup-validation.test.ts --config src/filesystem/vitest.config.tsnpm test --workspace @modelcontextprotocol/server-filesystemgit diff --checkFixes #4238.