You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice, defensive framing here — recovering after a bad frame is the right behavior.
One layering thought for the maintainers, since I just looked at the same class of bug in the SDK: the reason this needs ~240 lines of custom transport is that the SDK's own StdioServerTransport drops a malformed-but-recoverable frame (e.g. a request missing jsonrpc) — it routes the validation error to onerror but never replies, so a client tracking that id hangs. That's filed as modelcontextprotocol/typescript-sdk#2247, and a fix there makes the SDK transport reply with a JSON-RPC Invalid Request (-32600) when the offending message has a recoverable id.
If that lands in the SDK, the filesystem server (and every other server) could keep using the stock StdioServerTransport instead of maintaining a parallel one. Might be worth deciding where this should live long-term — a per-server transport works, but the SDK-level fix removes the need for it everywhere. Happy to share details from the SDK side if useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4206.
Fixes #4207.
Tests