Repository navigation
Conversation
Working group members are getting push access so they can open pull requests from branches in this repository. The org ruleset requires a code-owner approval before a merge, so naming the leads team here keeps approval with the leads and not with every member. The triggers-events-wg-leads team is created by a change in the access repository. Merge this only after that change has been deployed. A CODEOWNERS line that names a missing team is ignored.
pja-ant
marked this pull request as ready for review
October 16, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points CODEOWNERS at
@modelcontextprotocol/triggers-events-wg-leadsin place of@modelcontextprotocol/triggers-events-wg, so that approving a merge stays with the working group leads once ordinary members get push access.Working group members are being given
pushon this repository so they can open pull requests from branches here and not from forks. That change is in modelcontextprotocol/access#215, which also creates the leads team. The org ruleset onmainrequires a code-owner approval before a merge. If CODEOWNERS kept naming the whole working group, every new member's approval would count.Do not merge before modelcontextprotocol/access#215 is merged and deployed. The leads team does not exist until then, and a CODEOWNERS line that names a missing team is ignored, which would leave the repository with no code owner.
Between that deploy and this merge, anyone added to
triggers-events-wgis still a code owner. Merge this promptly afterwards.Test plan
Not runnable until the team exists. After the access change is deployed, check that GitHub shows no error banner on the CODEOWNERS file and that a pull request here requests review from the leads team.