Repository navigation
Conversation
Add an optional ValidationResult.confirmation field. A validator that sets it also returns valid: false and severity: "error", so invokers that don't implement confirmation block the request. Invokers that do may ask a human, then re-invoke the validator with context.confirmations bound to the payload's canonical hash and an expiry.
There was a problem hiding this comment.
🟡 Changes recommended
Approval binding does not adequately distinguish destinations or protect against receiving-side mutations after confirmation.
2 open findings
What changed in this PR
Extends the interceptor specification with human confirmation requests that remain blocking for invokers without confirmation support.
Changes:
- Adds confirmation request and response-context fields.
- Defines approval, revalidation, and audit-mode behavior.
- Documents confirmation binding and replay threats.
| File | Description |
|---|---|
| docs/sep.md | Specifies fail-closed human confirmation and security requirements. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Hash a call binding of event, phase, context.target and payload, so the same call to two servers has different hashes, and give each confirmation request an id tied to its pending invocation. Invokers must re-hash the payload actually sent or processed, after any later mutations, and block if it changed since it was approved.
This was referenced Oct 16, 2026
murthy-g
force-pushed
the
sep-validator-confirmation
branch
2 times, most recently
from
October 22, 2026 23:32
f5cfa53 to
c7af740
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to
docs/sep.md:ValidationResult: new optional fieldconfirmation(ConfirmationRequest:id,reason,callHash,expiresAt?,token?). Set together withvalid: falseandseverity: "error".{ event, phase, target, payload }thatcallHashcovers.context: new optionaltargetandconfirmations(interceptor,id,callHash,token?,decidedAt,principal?).No SDK changes.