Paramerterize shared library values#489
Open
dbrowne wants to merge 2 commits intomobilecoinfoundation:mainfrom
Open
Paramerterize shared library values#489dbrowne wants to merge 2 commits intomobilecoinfoundation:mainfrom
dbrowne wants to merge 2 commits intomobilecoinfoundation:mainfrom
Conversation
This should not be hardcoded but checked during build since ubuntu and rehl have different dir structures
parameterize library values
|
|
||
| static PATH_INITIALIZER: Lazy<Mutex<Option<PathInitializer>>> = Lazy::new(|| Mutex::new(None)); | ||
|
|
||
| const QUOTING_ENCLAVE: &str = "/usr/lib/x86_64-linux-gnu/libsgx_qe3.signed.so.1"; |
Collaborator
There was a problem hiding this comment.
I read the following from the motivation
Library names should not be hardcoded. The paths are not universal across Linux distributions.
but I'm not quite seeing how this address that. The paths are still hardcoded and aren't handling the different linux distributions.
I'm not advocating for logic to handle the different linux distributions here either. As it currently stands, it may be difficult to find the time to review a change such as that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the following constants
QUOTING_ENCLAVE
PROVISIONING_CERTIFICATE_ENCLAVE
ID_ENCLAVE
Motivation
Library names should not be hardcoded. The paths are not universal across Linux distributions.
Future Work