Skip to content

Allow merge commits#17

Open
nick-mobilecoin wants to merge 1 commit intomainfrom
nick/allow-merge-commits
Open

Allow merge commits#17
nick-mobilecoin wants to merge 1 commit intomainfrom
nick/allow-merge-commits

Conversation

@nick-mobilecoin
Copy link
Copy Markdown
Collaborator

Previously merge commits were disallowed. When using stacked PRs, if the
initial PR uses a squash merge, git and github loose the information to
associate the initial commits in subsequent PRs as belonging to the
initial PR. This results in github saying there are merge conflicts.
Using merge commits allows github to better keep track of which commits
are unique to each PR.

Motivation

Previously merge commits were disallowed. When using stacked PRs, if the
initial PR uses a squash merge, git and github loose the information to
associate the initial commits in subsequent PRs as belonging to the
initial PR. This results in github saying there are merge conflicts.
Using merge commits allows github to better keep track of which commits
are unique to each PR.
@nick-mobilecoin
Copy link
Copy Markdown
Collaborator Author

nick-mobilecoin commented May 5, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions Bot added the size/XS Extra-Small PRs label May 5, 2023
@meowblecoinbot meowblecoinbot requested a review from a team May 5, 2023 15:49
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2023

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags
clap 4.2.5 0 77 500 0 ____
hex_fmt 0.3.0 0 168 42 0 ____
displaydoc 0.2.3 0 409 68 24 ____
sha2 0.10.6 0 1061 114 204 ____
textwrap 0.16.0 0 2234 76 0 ____
nom 7.1.3 0 10471 33 40 ____

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2023

Codecov Report

Merging #17 (f67c064) into main (871334e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files           2        2           
  Lines         243      243           
=======================================
  Hits          193      193           
  Misses         50       50           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin requested a review from a team May 5, 2023 16:04
@nick-mobilecoin nick-mobilecoin enabled auto-merge (squash) May 5, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra-Small PRs

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants