when making swap proposals, optionally add fractional fee output#4026
Draft
cbeck88 wants to merge 4 commits intomobilecoinfoundation:mainfrom
Draft
when making swap proposals, optionally add fractional fee output#4026cbeck88 wants to merge 4 commits intomobilecoinfoundation:mainfrom
cbeck88 wants to merge 4 commits intomobilecoinfoundation:mainfrom
Conversation
this non-breaking change makes the swap proposals compatible with dex revisions after 55e0d4f121d7cb5c03e017c5027712dbe84feec7
every other grpc environment in mobilecoind has cq_count = 1, but this one doesn't. that means it creates a number of threads equal to the number of cores. that's likely wasteful and unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this non-breaking change makes the swap proposals compatible with latest deqs revisions
GenerateSwapRequestgets an optional number of fee basis points and a fee addressadditionally:
Motivation
in deqs revision 55e0d4f121d7cb5c03e017c5027712dbe84feec7, the deqs node may be configured to require fractional outputs like this for quotes to be valid, in order that they may collect fees.
Future Work
none