Fog view client by cbeck88 · Pull Request #3396 · mobilecoinfoundation/mobilecoin

cbeck88 · 2023-06-21T23:45:34Z

I created this client in order to dump summary stats from the fog-view response.

I got the following results:

$ ./target/docker/debug/fog_view_client --fog-view fog-view://fog.test.mobilecoin.com
...
2023-06-21 23:43:15.601404798 UTC INFO Highest processed block count: 1768001, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:37
2023-06-21 23:43:15.601854476 UTC INFO Num rng records: 31, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:38
2023-06-21 23:43:15.602249593 UTC INFO Num rng decommissioned: 23, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:39
2023-06-21 23:43:15.602408386 UTC INFO Num missed block events: 2, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:40
2023-06-21 23:43:15.602500398 UTC INFO Total missed blocks: 18, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:42

$ ./target/docker/debug/fog_view_client --fog-view fog-view://fog.prod.mobilecoinww.com
...
2023-06-21 23:44:14.992531319 UTC INFO Highest processed block count: 1653414, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:37
2023-06-21 23:44:14.992923765 UTC INFO Num rng records: 21, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:38
2023-06-21 23:44:14.993302427 UTC INFO Num rng decommissioned: 18, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:39
2023-06-21 23:44:14.993638321 UTC INFO Num missed block events: 0, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:40
2023-06-21 23:44:14.993893326 UTC INFO Total missed blocks: 0, mc.module: fog_view_client, mc.src: fog/view/connection/src/bin/client.rs:42

If I understand right, this means that mc-mainnet fog has never had a missed block event. That is frankly amazing.

TODO: I would like to be able to hit signal fog this way too.

* Update versions * Update lockfiles

nick-mobilecoin

This change should probably be based only against master. Currently this PR is trying to both merge 4.1.0 to master as well as bring in this new client.

Mostly nit comments

nick-mobilecoin · 2023-06-22T15:20:33Z

+    // Logging must go to stderr to not interfere with STDOUT
+    std::env::set_var("MC_LOG_STDERR", "1");


❓ What is the negative affect this prevents? I commented it out and saw nothing negative.

Initially I was thinking to make the final log lines be a json blob on stdout, but I ended up not doing that.
I still think it's usually good for tools to send logging to stderr.

nick-mobilecoin · 2023-06-22T15:21:47Z

+    //let mr_signer_verifier =
+    // mc_fog_view_enclave_measurement::get_mr_signer_verifier(None);
+
+    let mut verifier = Verifier::default();
+    verifier.debug(DEBUG_ENCLAVE); //.mr_signer(mr_signer_verifier);


🔧 Looks like there is some stray debug code here

Suggested change

//let mr_signer_verifier =

// mc_fog_view_enclave_measurement::get_mr_signer_verifier(None);

let mut verifier = Verifier::default();

verifier.debug(DEBUG_ENCLAVE); //.mr_signer(mr_signer_verifier);

let mut verifier = Verifier::default();

verifier.debug(DEBUG_ENCLAVE);

yeah we can do this -- honestly it may be better to try to ignore attestation as much as possible here.

nick-mobilecoin · 2023-06-22T15:24:31Z

+
+    match grpc_client.request(0, 0, vec![]) {
+        Ok(resp) => {
+            log::info!(logger, "Got response:\n{:?}", resp);


🙃 nit

Suggested change

log::info!(logger, "Got response:\n{:?}", resp);

log::info!(logger, "Got response:\n{resp:?}");

nick-mobilecoin · 2023-06-22T15:25:26Z

+                .iter()
+                .map(|range| range.end_block - range.start_block + 1)
+                .sum();
+            log::info!(logger, "Total missed blocks: {}", total_missed_blocks);


🙃

Suggested change

log::info!(logger, "Total missed blocks: {}", total_missed_blocks);

log::info!(logger, "Total missed blocks: {total_missed_blocks}");

nick-mobilecoin · 2023-06-22T15:25:44Z

+            log::info!(logger, "Total missed blocks: {}", total_missed_blocks);
+        }
+        Err(err) => {
+            log::error!(logger, "Got error:\n{}", err);


🙃

Suggested change

log::error!(logger, "Got error:\n{}", err);

log::error!(logger, "Got error:\n{err}");

nick-mobilecoin · 2023-06-22T15:26:09Z

+            .build(),
+    );
+
+    log::info!(logger, "Fog view attestation verifier: {:?}", verifier);


Suggested change

log::info!(logger, "Fog view attestation verifier: {:?}", verifier);

log::info!(logger, "Fog view attestation verifier: {verifier:?}");

nick-mobilecoin · 2023-06-22T15:29:43Z

+    match grpc_client.request(0, 0, vec![]) {
+        Ok(resp) => {


💭 This is good enough and seems to be inline with other outputs, but I'm curious who the intended audience is.
The reason is that the resp, while plain text, is not very ergonomic for human scanning as it is one line that is 7000 characters long.

we can make it debug log instead

James Cape and others added 2 commits March 22, 2023 13:09

Update Versions to 4.1.0 (#3273)

09062b2

* Update versions * Update lockfiles

add a client that can dump RNG and missed block totals from fog view

de8a2e8

cbeck88 requested review from dolanbernard, eranrund, holtzman, joekottke and nick-mobilecoin June 21, 2023 23:45

cbeck88 self-assigned this Jun 21, 2023

nick-mobilecoin reviewed Jun 22, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fog view client#3396

Fog view client#3396
cbeck88 wants to merge 2 commits intomainfrom
fog-view-client

cbeck88 commented Jun 21, 2023

Uh oh!

nick-mobilecoin left a comment

Uh oh!

nick-mobilecoin Jun 22, 2023

Uh oh!

cbeck88 Jun 22, 2023

Uh oh!

nick-mobilecoin Jun 22, 2023

Uh oh!

cbeck88 Jun 22, 2023

Uh oh!

nick-mobilecoin Jun 22, 2023

Uh oh!

nick-mobilecoin Jun 22, 2023

Uh oh!

nick-mobilecoin Jun 22, 2023

Uh oh!

nick-mobilecoin Jun 22, 2023

Uh oh!

nick-mobilecoin Jun 22, 2023

Uh oh!

cbeck88 Jun 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// Logging must go to stderr to not interfere with STDOUT
		std::env::set_var("MC_LOG_STDERR", "1");

	log::info!(logger, "Got response:\n{:?}", resp);
	log::info!(logger, "Got response:\n{resp:?}");

	log::info!(logger, "Total missed blocks: {}", total_missed_blocks);
	log::info!(logger, "Total missed blocks: {total_missed_blocks}");

	log::error!(logger, "Got error:\n{}", err);
	log::error!(logger, "Got error:\n{err}");

	log::info!(logger, "Fog view attestation verifier: {:?}", verifier);
	log::info!(logger, "Fog view attestation verifier: {verifier:?}");

Conversation

cbeck88 commented Jun 21, 2023

Uh oh!

nick-mobilecoin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants